[hotfix] Fix Service account typo #285
Conversation
|
I'd propose banning the plural in English. |
| @@ -54,7 +54,7 @@ rules: | |||
| - apiGroups: | |||
| - "" | |||
| resources: | |||
| - serviceaccount | |||
| - serviceaccounts | |||
There was a problem hiding this comment.
why do we need this change? serviceaccount should be correct.
There was a problem hiding this comment.
If we need serviceaccount, we should update code
Change serviceaccount to serviceaccounts and make manifest to auto generate role.yaml
There was a problem hiding this comment.
It turns out the plural form is the correct way to specify the resource name (compare to "pods" and "services" elsewhere in this file).
With "serviceaccount" (singular) it fails to grant the necessary permissions (which are used only to set up the autoscaler's service account)
There was a problem hiding this comment.
If we need
serviceaccount, we should update code
Thanks for pointing that out!! Will do.
|
One apple, ten apple. |
Fixes a typo in the operator's role that prevents it from managing service accounts, which in turn blocks setup of autoscaling Ray clusters.
Why are these changes needed?
Fixes a typo in the operator's role that prevents it from managing service accounts, which in turn blocks setup of autoscaling Ray clusters.
TODO: How to test??
Related issue number
Checks